Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/web3ext: fix eth_call stateOverrides in console #26265

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Nov 28, 2022

web3.js's eth_call which we were defaulting to doesn't have the stateOverrides parameter, so this param wasn't working in the console.

This came up when looking into #26088.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.11.0 milestone Nov 28, 2022
@holiman holiman merged commit 1325fef into ethereum:master Nov 28, 2022
s1na added a commit that referenced this pull request Nov 28, 2022
holiman pushed a commit that referenced this pull request Nov 28, 2022
Fixes a regression from #26265, which made it so that the call only worked if all three parameters were provided.
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
)

web3.js's eth_call which we were defaulting to doesn't have the stateOverrides parameter, so this param wasn't working in the console.
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
Fixes a regression from ethereum#26265, which made it so that the call only worked if all three parameters were provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants